Use after_commit callbacks for real-time changes. #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can vary depending on engine/version, and it really doesn't matter.
I don't know why this was an issue on my machine, but not in CI.
Prompted by #1203. It certainly makes more sense to wait until the database changes are fully committed before we update Sphinx. Testing real-time indices with transactional fixtures should continue to work, because Sphinx is being updated via the Rails apps, rather than by talking to the database directly (the latter being the case for SQL-backed indices).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also applies to deletions generally (no matter what type of indices are in play).
This was prompted by feedback from @krauselukas in #1203. It certainly makes more sense to wait until the database changes are fully committed before we update Sphinx, so I feel like this switch is a smart one.