decide per index to reconcile class name field #1222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently we only remove the class name field if there's no index with inheritance at all among the ones defined. This commit reconciles all possible indices, skipping only the ones where this field is needed.
|
The logic on this seems fine to me, but CI's not happy - even though the tests pass on my own machine. I'm going to try to figure out why (and maybe migrate CI over to GitHub Actions now that they support retrying of failed jobs, see if that helps) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently we only remove the class name field
if there's no index with inheritance at all
among the ones defined. This commit reconciles
all possible indices, skipping only the ones
where this field is needed.