Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pivot should not add to collapsedRows if the row cannot be collapsed #37

Closed
turnerniles opened this issue Mar 15, 2017 · 1 comment
Closed

Pivot should not add to collapsedRows if the row cannot be collapsed #37

turnerniles opened this issue Mar 15, 2017 · 1 comment

Comments

@turnerniles
Copy link
Collaborator

turnerniles commented Mar 15, 2017 •
edited
Loading

If user runs pivot.collapse(2); and the second row does not contain collapsable children, {2: undefined} is added to pivot.collapsedRows. Instead nothing should be added.
turnerniles added a commit that referenced this issue Mar 15, 2017
@turnerniles
fix for #37
6767b73
pat310 added a commit that referenced this issue Mar 18, 2017
@pat310
Merge pull request #38 from pat310/stop-collapsing-at-lowest-level
35528f0 
fix for #37
@pat310
Copy link
Owner

pat310 commented Mar 18, 2017

Closed in #38

@pat310 pat310 closed this as completed Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turnerniles @pat310