Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive filtering modification #54

Merged
merged 7 commits into from
Jun 26, 2017

Conversation

turnerniles
Copy link
Collaborator

Upon filtering sets originalArgs.data equal to the filtered data which is then used in successive filter method calls.

This naming is confusing since originalArgs.data will not always contain the originalArgs and will contain the "filteredArgs" but I don't think we need to add an additional filteredArgs property to the Pivot class. this.originalData is also set equal to the result of the filtered data in the update method so perhaps we should consider renaming originalArgs and originalData.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 98.624% when pulling 4908341 on progressive-filtering-modification into ee28233 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 98.624% when pulling 0a4bbf4 on progressive-filtering-modification into ee28233 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 98.624% when pulling 482103d on progressive-filtering-modification into ee28233 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 98.624% when pulling 4d7e399 on progressive-filtering-modification into ee28233 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 98.624% when pulling f089438 on progressive-filtering-modification into ee28233 on master.

Copy link
Owner

@pat310 pat310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@pat310 pat310 merged commit 5530e9b into master Jun 26, 2017
@pat310 pat310 deleted the progressive-filtering-modification branch June 26, 2017 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants