changes aggregated text to total #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat310
reviewed
Jan 20, 2018
test/logic/tableCreator.js
Outdated
| @@ -246,9 +246,10 @@ export default () => { | |||
| () => { | |||
| const tableResults = tableCreator(data, ['borough'], [], 'age', | |||
| 'count'); | |||
| console.log('table', tableResults.table[0]) | |||
There was a problem hiding this comment.
good spotting!
|
@turnerniles ☝️ |
|
@pat310 Updated the README, removed console.log and increased package version patch number. 'Aggregated' or 'aggregated' in both places could also work. |
pat310
approved these changes
Jan 27, 2018
pat310
added a commit
that referenced
this pull request
Jan 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #69. I see text such as, 'Totals', 'Grand Total' in other projects. This PR change the row and column header text to 'Totals'. What do you think @pat310?