Support of echo with chords inside #205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Je risque d'avoir besoin d'un support de
\echo{}
dans des fichiers chordpro pour un projet perso, voici donc une PR pour proposer une implémentation.Il faut notamment permettre les accords au sein de ces
echo
.Je propose la paire
{start_echo}
,{end_echo}
sans leof
, car ce ne sont pas des paragraphes (commechorus
/bridge
).Qu'en pensez-vous ?
Est-ce que la syntaxe vous convient ? Est-ce que l'implémentation semble correcte ?