Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting image sizes #218

Merged
merged 14 commits into from
May 10, 2016
Merged

Allow setting image sizes #218

merged 14 commits into from
May 10, 2016

Commits on May 4, 2016

  1. [WIP] Image size: write tests

    Louis committed May 4, 2016
    Configuration menu
    Copy the full SHA
    8cfe6be View commit details
    Browse the repository at this point in the history

Commits on May 5, 2016

  1. More tests

    Louis committed May 5, 2016
    Configuration menu
    Copy the full SHA
    7c476a7 View commit details
    Browse the repository at this point in the history

  2. More tests

    Louis committed May 5, 2016
    Configuration menu
    Copy the full SHA
    b85a88a View commit details
    Browse the repository at this point in the history

  3. [WIP] Error works, and chordpro to chordpro image conversion works 

    [CI SKIP]
    Louis committed May 5, 2016
    Configuration menu
    Copy the full SHA
    6c29053 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2016

  1. [WIP][Image size] Refactoring

    Louis committed May 6, 2016
    Configuration menu
    Copy the full SHA
    29e0ac9 View commit details
    Browse the repository at this point in the history

  2. [WIP][Image size] LaTeX generation works

    Louis committed May 6, 2016
    Configuration menu
    Copy the full SHA
    acd13c8 View commit details
    Browse the repository at this point in the history

  3. [WIP][Image size] Seems to work

    Louis committed May 6, 2016
    Configuration menu
    Copy the full SHA
    b20cc79 View commit details
    Browse the repository at this point in the history

  4. pylint

    Louis committed May 6, 2016
    Configuration menu
    Copy the full SHA
    5fb090a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2016

  1. _render_size is no longer a method of the abstract class

    Louis committed May 7, 2016
    Configuration menu
    Copy the full SHA
    5f05d8c View commit details
    Browse the repository at this point in the history

Commits on May 8, 2016

  1. Try to be more pythonic for size checks 

    Slight behoavior differences between all() and != (None,None):
- all() requires ALL terms to be not None (where (None, "cm") would pass
  != (None,None))
- all() checks for None or 0 or empty string
	No empty unit is supported (yet)
	A size of 0 does not really makes sense (and currently is passed
since it is the string "0")
    @oliverpool
    oliverpool committed May 8, 2016
    Configuration menu
    Copy the full SHA
    60f6060 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2016

  1. Change syntax of image directive arguments: `{image: foo.png width=3c… 

    …m height=2cm}`
    Louis committed May 9, 2016
    Configuration menu
    Copy the full SHA
    f4e1243 View commit details
    Browse the repository at this point in the history

  2. Improve error messages

    @oliverpool
    oliverpool committed May 9, 2016
    Configuration menu
    Copy the full SHA
    346f630 View commit details
    Browse the repository at this point in the history

  3. Minor refactoring for error checking

    @oliverpool
    oliverpool committed May 9, 2016
    Configuration menu
    Copy the full SHA
    cbe34b9 View commit details
    Browse the repository at this point in the history

  4. Micro-optimization (just for fun)

    @oliverpool
    oliverpool committed May 9, 2016
    Configuration menu
    Copy the full SHA
    99bee51 View commit details
    Browse the repository at this point in the history