fix(pat-5034): c# - include order-by when computing group-by

[ajmasci]

• Include order-by expressions when computing group-by clause.

Test plan

• Added unit tests.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

[ajmasci]

Current dependencies on/for this PR:

• main
  • PR fix(pat-5034): include order-by expressions when computing the group-by clause #208
    • PR fix(pat-5034): python - include order-by when computing group-by #209
      • PR fix(pat-5034): c# - include order-by when computing group-by #210 👈

This stack of pull requests is managed by Graphite.

[spencerwilson]

Huh, the RHS of this expression is interesting:

x.GetType().Name == typeof(AggregateFieldExpr<>).Name

Can you explain this a little bit? I'm not sure how to read it. It almost looks like the expression as a whole is acting as an existential qualifier ("there exists some type of AggregateFieldExpr whose name is equal to x.GetType().Name").

[ajmasci]

Yeah, this is the equivalent of the x instanceof AggregateFieldExpr.
I recall having a bit of a struggle to figure this out. Not sure if there's a more direct way to do this in C# for a template type.

[graphite-app]

Merge activity

• Dec 19, 5:33 PM: @ajmasci added this pull request to the Graphite merge queue.

[graphite-app]

Merge activity

• Dec 19, 5:35 PM: @ajmasci merged this pull request with the Graphite merge queue.