Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exact as default #29

Open
frederikhors opened this issue Apr 10, 2020 · 1 comment
Open

exact as default #29

frederikhors opened this issue Apr 10, 2020 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@frederikhors
Copy link
Contributor

Maybe a breaking change but I think we need this.

From Readme:

<Router>
  <Route exact>Hello World</Route>
  <Route exact path="/svelte-component" component={SvelteComponent}/>
  <Route exact path="/promise" component={import('path/to/other-component.svelte')}/>
  <Route exact path="/async" component={() => import('path/to/another-component.svelte')}/>
</Router>

Can we omit exact? Can we use it as default?

All my routes are exact.

Can we use not-exact or similar for when not exact?

@pateketrueke
Copy link
Owner

pateketrueke commented Apr 10, 2020

Nope, I mean, we could add exact support on top-level <Router /> so it just inherit down.

But making it default will break nested routes and such.

What do you think?

@pateketrueke pateketrueke added enhancement New feature or request question Further information is requested labels Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants