Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified forward_signals to be compatible with windows #4

Merged
merged 1 commit into from Mar 30, 2022

Conversation

gpfv
Copy link
Contributor

@gpfv gpfv commented Mar 30, 2022

in regard to issue #3

removed signal.SIGTERM from forward_signals, as well as two others as they could not be used by signal.signal (ValueError: invalid signal value)

from https://docs.python.org/3/library/signal.html
signal.CTRL_C_EVENT
The signal corresponding to the Ctrl+C keystroke event. This signal can only be used with os.kill()

same for signal.CTRL_BREAK_EVENT

@twavv twavv merged commit 68699c8 into pathbird:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants