This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
PHR-7233 - Move commons-hibernate optimizer to pkb-common #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symore
previously approved these changes
Oct 15, 2020
There was a problem hiding this comment.
My concern is that this change pulls in hibernate dependencies transitively into dependant projects that might not work with hibernate. Otherwise if i imagine pkb-common as a library containing supportive stuff, this can go trough.
However, making large common libraries can highly complicate dependency hierarchies.
ratkayandras
approved these changes
Oct 20, 2020
DMWhiteley
deleted the
feature/PHR-7233_move_hibernate_resources_to_pkb_common
branch
MFAshby
pushed a commit
that referenced
this pull request
Jul 5, 2022
…bernate_resources_to_pkb_common PHR-7233 - Move commons-hibernate optimizer to pkb-common
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves ResettablePooledLoOptimizer to pkb-common. This is a hibernate-specific resource, and we don't want to entwine it with the phr data structures unnecessarily. Some services will use this even though they don't otherwise need access to omni, i.e. services which maintain their own databases.
Added in suppressions for hibernate-core previously ignored in commons-hibernate repo.