This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Reduce dependency footprint of spring data kotlin helper #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkbdevdeploy
reviewed
Mar 2, 2021
symposion
force-pushed
the
feature/phr-6511-external-id-refactor
branch
from
5930aec
to
8e7888b
Compare
symposion
changed the title
symposion
commented
Mar 3, 2021
| @@ -36,6 +40,7 @@ | |||
| try { | |||
| return Optional.of(wrappedParser.apply(str)); | |||
| } catch (NumberFormatException e) { | |||
| LOGGER.error("Bad config property value [{}] was supposed to be a number but wasn't parseable", str, e); | |||
There was a problem hiding this comment.
This was changed to keep the static analysis happy.
pkbdevdeploy
reviewed
Mar 3, 2021
MFAshby
previously approved these changes
Mar 3, 2021
|
should remain draft until we've verified it works with downstream projects |
matevarga
reviewed
Apr 21, 2021
suppression.xml
Outdated
| @@ -19,12 +19,12 @@ | |||
| ]]></notes> | |||
| <vulnerabilityName regex="true">CVE-2019-14900|CVE-2020-25638</vulnerabilityName> | |||
| </suppress> | |||
| <suppress until="2021-03-01Z"> | |||
| <suppress until="2021-04-01Z"> | |||
There was a problem hiding this comment.
No. It doesn't. It might have done a month ago when I first opened this PR. Sigh.
matevarga
approved these changes
Apr 22, 2021
MFAshby
approved these changes
Apr 22, 2021
MFAshby
added a commit
that referenced
this pull request
Jul 5, 2022
…l-id-refactor Reduce dependency footprint of spring data kotlin helper
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our kotlin version of Spring Data Persistable had an unnecessary dependency on a spring boot starter rather than just the Spring Data jar. It also could have had the dependency as provided to avoid dependency clashes.