HMS integration #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate CoLocation into two implementations: 1. `CoLocationGms` - GMS implementation 2. `CoLocationHms` - HMS implementation Let the `CoLocation.from` decide which `locationServicesSource` to use: when both GMS and HMS are available then use the GMS. Create `LocationRequest` and `LocationSettingsRequest` which are wrappers to the platform related classes and use them to define requests without using specific (GMS/HMS) classes. Change the minSdkVersion to 19 (HMS requirement). Create separate tests for both tools.
Add HMS integration
Add ability to switch between location providers.
Modify Sample app to be able to test HMS on Huawei devices
Open
OKatrych
commented
Nov 3, 2021
| @@ -47,6 +49,8 @@ dependencies { | |||
| implementation "androidx.lifecycle:lifecycle-runtime-ktx:2.3.1" | |||
| implementation "androidx.lifecycle:lifecycle-extensions:2.2.0" | |||
|
|
|||
| implementation "androidx.multidex:multidex:2.0.1" | |||
|
Thanks for the contribution, it's really appreciated. Without looking too much into details of the PR, if HMS integration should be added, it should not be in the main library, but as a second library which depends on the main library, as an add on. Otherwise this would introduce HMS dependency even when users of the library only need to use Google services - which is probably still the most common way of using this library. If this is reworked in a way so that the HMS implementation is moved to a |
Update dependencies versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate CoLocation into two implementations:
CoLocationGms- GMS implementationCoLocationHms- HMS implementationLet the
CoLocation.fromdecide whichlocationServicesSourceto use:when both GMS and HMS are available then use the GMS.
Create
LocationRequestandLocationSettingsRequestwhich are wrappersto the platform related classes and use them to define requests without
using specific (GMS/HMS) classes.
Change the minSdkVersion to 19 (HMS requirement).
Create separate tests for both tools.
Modify Sample app to be able to test HMS on Huawei devices