This repository has been archived by the owner on Jun 5, 2023. It is now read-only.
Request permission only when called by js #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library initialised CBCentralManager on module init which inits directly in application didFinishLaunching. This caused bluetooth permission to pop up the moment app is launched. This is now avoided by initialising CBCentralManager only when js side calls a module function for the first time
|
Released in v1.3.1 |
|
Sorry for the delay. Had to fix the "Unknown" state before releasing it to avoid a breaking change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library initialised CBCentralManager on module init which inits directly in application didFinishLaunching. This caused bluetooth permission to pop up the moment app is launched. This is now avoided by initialising CBCentralManager only when js side calls a module function for the first time. Please note that this change will give state as "Unknown" on the first
getState()call