Fix ArrayQueue #55
Merged
Fix ArrayQueue #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 5, 2017 17:03
ArrayQueue::resize() needs the max() function from utils in order to compile.
The member `a` is not dynamically allocated and so should not be deleted.
patmorin
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be two small bugs in the
ArrayQueuecode--theresize()method needs themax()function from theutilsheader, but the header isn't included. And the destructor deletes thearray a, butawasn't dynamically allocated to begin with. (Thanks to my students for pointing these out!)