tools: Reduced some common duplicate code #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoyvwac
force-pushed
the
fix/condense-and-use-std-algorithms-tools
branch
from
d84b32a
to
0ac2cda
Compare
|
This is great! thank you! |
text.cpp: * Moved duplicate code into own functions. * Moved the common functions to anonymous namespace. * Prefer standard algorithms and standard datatypes. * Prefer tag-dispatching for specialised regex search queries.
tcoyvwac
force-pushed
the
fix/condense-and-use-std-algorithms-tools
branch
from
4041a39
to
d0a5026
Compare
text.cpp: * Converted output pass-by-references to more understandable & context- friendly-tailored member variables (for a specialised function-object).
tcoyvwac
force-pushed
the
fix/condense-and-use-std-algorithms-tools
branch
from
d270120
to
d8f0c14
Compare
|
Thanks for your positive feedback & encouragement @patriciogonzalezvivo! 馃帀 The PR is basically finished now. I hope it was understandable! |
|
This is fantastic! Thank you so much! Deeply appreciate the time and care you put on it. It's way smarter. Love the reusable structure. I'm learning a lot from it. |
|
Thanks for the merge & once again encouragement @patriciogonzalezvivo. Grateful! 馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @patriciogonzalezvivo! 馃樃
Noticed some lines-of-code could be reduced a bit. Wanted to help by moving some common code to their own local functions and/or preferring to use some available standard-library algorithms (which performs the same thing).
Also using a simple keyword datatype to hopefully make the code more readable and modular.
Thank you for your very useful project and great project BTW! 馃帀