fix: (VERA) Prefer smart pointers over raw pointers #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoyvwac
changed the title
tcoyvwac
changed the title
|
Exiting! |
sandbox.cpp: * Made cursor vbo use std::unique_ptr.
tcoyvwac
force-pushed
the
fix/vera/prefer-smart-pointer-over-raw-pointer
branch
from
6db639f
to
c8f7145
Compare
sandbox: * Made m_plot_texture use std::unique_ptr.
sceneRender: * Made m_grid_vbo use std::unique_ptr.
sceneRender: * Made m_axis_vbo use std::unique_ptr.
sceneRender: * Made m_floor_vbo use std::unique_ptr.
sceneRender: * Made m_lightUI_vbo use std::unique_ptr.
sceneRender: * Made m_cubemap_vbo use std::unique_ptr.
|
Ok @patriciogonzalezvivo, these twin PRs are basically finished. If there are no extra requests or recommendations, feel free to merge please! 😸 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @patriciogonzalezvivo,
As the project is a C++11 project, this PR helps replace some raw pointers with smart pointers to help prevent unknown memory leaks.
(This is a twin PR, but for the VERA branch of the project, as requested in PR:#276's comment)