Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide glslViewer from desktop menus #281

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Hide glslViewer from desktop menus #281

merged 1 commit into from
Aug 8, 2022

Conversation

jnsh
Copy link
Contributor

@jnsh jnsh commented Aug 8, 2022

Starting glslViewer requires passing shader filenames as command line
arguments, otherwise it will exit immediately. Launching glslViewer
via the desktop entry (i.e. from desktop environment menu) can not
pass filenames as arguments, and therefore it fails without any
message to the user.

Hide the unusable application entry from desktop menus. The desktop
entry is still useful for opening associated MIME types from e.g.
file managers.

This is intended usage of the NoDisplay desktop entry key, see https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys.

Starting glslViewer requires passing shader filenames as command line 
arguments, otherwise it will exit immediately. Launching glslViewer 
via the desktop entry (i.e. from desktop environment menu) can not 
pass filenames as arguments, and therefore it fails without any 
message to the user.

Hide the unusable application entry from desktop menus. The desktop 
entry is still useful for opening associated MIME types from e.g. 
file managers.
@patriciogonzalezvivo
Copy link
Owner

Thank you!

@patriciogonzalezvivo patriciogonzalezvivo merged commit 99a990a into patriciogonzalezvivo:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants