Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add a kaleidoscopic space transformation #111

Merged

Conversation

marioecg
Copy link
Contributor

@marioecg marioecg commented Nov 8, 2023

No description provided.

@patriciogonzalezvivo
Copy link
Owner

@marioecg this is perfect! wonder if the overloading functions with less argument can be just calls to the third (and longer) but with the defaults. So there is less repeating code. Beside that this is absolutely perfect

@marioecg
Copy link
Contributor Author

marioecg commented Nov 9, 2023

@patriciogonzalezvivo oh you're right! I'll be pushing all those changes in short. Could you check that the change for CENTER_2D is correct? I am a little uncertain if that's how you should use it like.

@patriciogonzalezvivo
Copy link
Owner

Beautiful!

@patriciogonzalezvivo patriciogonzalezvivo merged commit 459b0e9 into patriciogonzalezvivo:main Nov 9, 2023
@patriciogonzalezvivo
Copy link
Owner

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants