Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A patch for the Japanese translation #237

Merged
merged 1 commit into from
Mar 5, 2019
Merged

A patch for the Japanese translation #237

merged 1 commit into from
Mar 5, 2019

Conversation

Keyaki-v
Copy link
Contributor

@Keyaki-v Keyaki-v commented Mar 5, 2019

Hello,

This is a small patch for the Japanese translation in chapter 11.
I changed some mathematical expressions in Japanese.

... with a quintic interpolation curve ( f(x) = 6x^5-15x^4+10x^3 )

The "4次エルミート曲線" is not a correct translation of "quintic interpolation curve".
I think that "5次式の曲線" would be better.

Thanks.

@patriciogonzalezvivo patriciogonzalezvivo merged commit 5559431 into patriciogonzalezvivo:master Mar 5, 2019
@patriciogonzalezvivo
Copy link
Owner

Thanks!

@Keyaki-v
Copy link
Contributor Author

Keyaki-v commented Mar 5, 2019

Thank you too. This is a great book!

@Keyaki-v
Copy link
Contributor Author

Hi @patriciogonzalezvivo,
It seems that this PR has already merged but https://thebookofshaders.com/11/?lan=jp has not updated yet. Is there anything else I should do?

@Keyaki-v
Copy link
Contributor Author

Keyaki-v commented Nov 4, 2019

It seems that this PR has already merged but https://thebookofshaders.com/11/?lan=jp has not updated

Now I've confirmed that the page updated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keyaki-v @patriciogonzalezvivo