Now running tree_check when initialising a Module #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n eqx.nn thing, not an eqx thing.
…ates its input as being a scalar index.
…pointed out that otherwise this can silently normalise over sequence dimensions in transformer models if you miss the vmap)
patrick-kidger
force-pushed
the
module-check
branch
from
3dc5fac
to
de5a982
Compare
patrick-kidger
force-pushed
the
module-check
branch
from
de5a982
to
0c7849f
Compare
…eaving it on permanently by accident.
Previously, this was erroneously skipped when the function lacked any closed-over variables. In addition, this commit adds eqxi.cached_filter_eval_shape, as that is needed for the above.
… __init__. This emerged as a prerequisite to having #491 give the desired behaviour.
… an extra argument. It no longer mutates its input.
…ntary pattern but I find myself needing a reference to this quite frequently...
patrick-kidger
force-pushed
the
module-check
branch
from
0c7849f
to
77ab1ce
Compare
patrick-kidger
force-pushed
the
module-check
branch
from
77ab1ce
to
9e1c5d1
Compare
patrick-kidger
force-pushed
the
dev
branch
2 times, most recently
from
b8e3165
to
57afee1
Compare
patrick-kidger
force-pushed
the
main
branch
2 times, most recently
from
2905390
to
a386f27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly experimental idea. It'd be great to run tree_check automatically, to validate that there aren't any accidental repeated layers.
In practice I wouldn't be surprised if there's a fair amount of deliberate repetition, from users intending to have things turn into duplicates. So it may turn out that we can't merge this.