Only allow safe identifiers as object keys (Fixes babel#416)

patrick-steele-idem · Feb 28, 2017 · 1dd1486 · 1dd1486
1 parent ca9c3fe
commit 1dd1486
Showing 1 changed file with 17 additions and 1 deletion.
diff --git a/packages/babel-plugin-transform-property-literals/src/index.js b/packages/babel-plugin-transform-property-literals/src/index.js
@@ -1,5 +1,11 @@
 "use strict";
 
+const safeIdentifierRegExp = /[^a-z0-9$_]/i;
+
+function isSafeKeyIdentifier(t, value) {
+  return !safeIdentifierRegExp.test(value) && t.isValidIdentifier(value);
+}
+
 module.exports = function({ types: t }) {
   return {
     name: "transform-property-literals",
@@ -8,14 +14,24 @@ module.exports = function({ types: t }) {
       ObjectProperty: {
         exit({ node }) {
           const key = node.key;
+
+          // Handle the case where the incoming property key may not be a safe
+          // identifier that works in all browsers
+          if (t.isIdentifier(key)) {
+            if (!isSafeKeyIdentifier(t, key.name)) {
+              node.key = t.stringLiteral(key.name);
+            }
+            return;
+          }
+
           if (!t.isStringLiteral(key)) {
             return;
           }
 
           if (key.value.match(/^\d+$/)) {
             node.key = t.numericLiteral(parseInt(node.key.value, 10));
             node.computed = false;
-          } else if (t.isValidIdentifier(key.value)) {
+          } else if (isSafeKeyIdentifier(t, key.value)) {
             node.key = t.identifier(key.value);
             node.computed = false;
           }