Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code improvements and version updates #68

Merged
merged 8 commits into from
Feb 23, 2023
Merged

Conversation

patrickdappollonio
Copy link
Owner

@patrickdappollonio patrickdappollonio commented Feb 20, 2023

This PR:

  • Uses testify/assert to reduce the number of lines written in tests and increase yours truly's proficiency 🤣
  • Upgrades several stuff like:
    • Dependencies (moved back to Cobra now that the package doesn't add additional dependencies; updated GHA versions)
    • Sort order (now includes IngressClass)
    • Goreleaser (now there's a name_template that's deprecated that is no longer in use)
  • The number of empty whitespaces before, between and after a file has been removed to make it more predictable
    • While I consider this a small change since the behaviour of the YAML code doesn't change here, I would request people to provide a review on this
  • Unit tests with fixtures for the core program
    • I plan to expand this further so any drop-in file can be unit-tested.

@patrickdappollonio patrickdappollonio changed the title Code improvements. Code improvements and version updates Feb 20, 2023
@patrickdappollonio patrickdappollonio merged commit 9e08b8d into main Feb 23, 2023
@patrickdappollonio patrickdappollonio deleted the improvements branch February 23, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant