Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#114 - this is a first attempt at getting the text or rich text value… #235

Merged

Conversation

robertjf
Copy link
Contributor

…s from a block list or grid for description meta fields

…rich text values from a block list or grid for description meta fields
@patrickdemooij9
Copy link
Owner

Looking very good for a first version @robertjf!

Did find a small bug in that, if your value is coming from a TinyMCE, it will also take the HTML, but I am sure that can be solved. The only thing that I "worry" about is that the component does feel a bit like magic as you don't know what it does, but not quite sure how to solve that.
Might just need to write some documentation, so that people can find what it currently does.

@robertjf
Copy link
Contributor Author

yep - I'll get the HTML bit fixed up and push up a change.

And yes with the documentation.

@robertjf
Copy link
Contributor Author

@patrickdemooij9 the HTML issue is resolved... where do you maintain the documentation for this?

@patrickdemooij9
Copy link
Owner

Perfect! The documentation is here: https://seotoolkit.gitbook.io/useotoolkit/. But don't worry, I'll make sure to write a bit about it!

@patrickdemooij9
Copy link
Owner

Great first version! Hopefully we can build upon it in future versions, but this will definitely help people out there.

@patrickdemooij9 patrickdemooij9 merged commit 8707534 into patrickdemooij9:dev/Umbraco11 Sep 23, 2023
patrickdemooij9 pushed a commit that referenced this pull request Oct 12, 2023
#235)

* #114 - this is a first attempt at getting the text or rich text values from a block list or grid for description meta fields

* Added checking for html encoded strings and stripping the html.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants