Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traverse app and config parent directories when looking up modules #27

Merged

Conversation

MartinBriza
Copy link
Contributor

When running something from the build folder, it was really hard to set up the paths properly and it would have to be done manually in most cases. Traversing up from the binary makes it a lot easier. It also takes preference over the config dir because there may be clashes between dir names and the ones in build dir should be preferred.

I'm not sure about the macro constant, not very idiomatic C++, I know.

I know qhot can be integrated in Qt Creator but this makes it way easier to integrate it into CMake and you get automatic setup 'for free', check out this commit in my project to see how I use it: LithApp/Lith@1197bd4 .

In case you want to discuss anything about the PRs I opened today, feel free to hit me on m@rtinbriza.cz or ping Bizon on libera.chat. Thanks for this awesome tool, it will make my life a lot easier!

When running something from the build folder, it was really hard to set
up the paths properly and it would have to be done manually in most
cases. Traversing up from the binary makes it a lot easier. It also
takes preference over the config dir because there may be clashes
between dir names and the ones in build dir should be preferred.
@patrickelectric
Copy link
Owner

I need to think more about it when looking closer, I'll try to get back on it during the weekend.

BTW, thanks for the PRs!

@MartinBriza
Copy link
Contributor Author

Thanks for merging the others and responding so fast! Yes, this could probably use more control, especially about the recursion but I didn't want to add too many arguments at the same time. However I'm fine with any way to go about this, just let me know when you have time. :) Until then I'll just use my fork, there may be some more changes anyway because Windows is annoying.

@patrickelectric patrickelectric merged commit 50e2091 into patrickelectric:master Oct 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants