Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple deps per layer #423

Conversation

andremarianiello
Copy link
Contributor

Fixes #422

@patrickhoefler
Copy link
Owner

Hey @andremarianiello,

thank you very much for your contribution! Unfortunately something doesn't seem quite right yet.

Also, please make sure to include a test that covers the fix — convert_test.go is probably a good place for that.

Once again, thank you, and please let me know if you have any questions or run into any issues!

@patrickhoefler patrickhoefler added the bug Something isn't working label Nov 14, 2023
@andremarianiello andremarianiello force-pushed the support-multiple-deps-per-layer branch 3 times, most recently from 511aeef to 0739bad Compare November 14, 2023 16:29
@andremarianiello andremarianiello force-pushed the support-multiple-deps-per-layer branch 2 times, most recently from 1b7e8cc to 2e309e1 Compare November 14, 2023 16:38
Copy link
Owner

@patrickhoefler patrickhoefler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your excellent contribution!

@patrickhoefler patrickhoefler enabled auto-merge (squash) November 14, 2023 17:04
@andremarianiello
Copy link
Contributor Author

LGTM. Thanks for your excellent contribution!

You're welcome!

@patrickhoefler patrickhoefler merged commit 2afb05b into patrickhoefler:main Nov 14, 2023
8 checks passed
@andremarianiello andremarianiello deleted the support-multiple-deps-per-layer branch November 14, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple --mount=from=* seem unsupported
2 participants