Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: better coverage for ExtractTextPlugin use cases #15

Merged
merged 1 commit into from
Feb 12, 2019
Merged

tests: better coverage for ExtractTextPlugin use cases #15

merged 1 commit into from
Feb 12, 2019

Conversation

mochiya98
Copy link
Contributor

refs: #13, #14

@patrickhulce
Copy link
Owner

Thanks @mochiya98! These are tests just for the case that's already been fixed in #13 and the #14 case is different, correct? So they would be failing prior to 2.0.2?

@mochiya98
Copy link
Contributor Author

mochiya98 commented Feb 12, 2019 •
edited
Loading

sorry, #14 means that the patch is "incomplete".
that's right. this test is failed on 2.0.1. (for testing #13)

@patrickhulce patrickhulce changed the title Add minify tests for ExtractTextPlugin tests: better coverage for ExtractTextPlugin use cases Feb 12, 2019
@patrickhulce patrickhulce merged commit 2e993af into patrickhulce:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mochiya98 @patrickhulce