Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary options in the configuration file #203

Closed
pavlozt opened this issue Dec 15, 2023 · 3 comments
Closed

Support arbitrary options in the configuration file #203

pavlozt opened this issue Dec 15, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@pavlozt
Copy link

pavlozt commented Dec 15, 2023

Sometimes (and in the future) it becomes necessary to add options that the role creator did not provide
For example, I need override backoff_config. But I don't find any global level variable.
Other people have also mentioned limits_config, etc.

@pavlozt
Copy link
Author

pavlozt commented Jan 6, 2024

Ok. This is not so actual options. backoff_config is part of promtail_config_clients.

@patrickjahns patrickjahns added the enhancement New feature or request label Feb 14, 2024
@patrickjahns
Copy link
Owner

I understand your request - how would you propose that this could be best addressed and resolved?
Is it possible to address this without introducing a breaking change to the current behaviour ?

@pavlozt
Copy link
Author

pavlozt commented Feb 15, 2024

@patrickjahns I suggest leaving everything as is. promtail_config_clients solves the problem.
There are not many options in this program and I have no burning practical need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants