inject resetAndDestroy into socket in test for older versions of node

patrickjuchli · Oct 16, 2023 · 17322c2 · 17322c2
1 parent d077116
commit 17322c2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/test/MockFtpServer.js b/test/MockFtpServer.js
@@ -39,6 +39,15 @@ module.exports = class MockFtpServer {
         })
         this.dataConn = undefined
         this.dataServer = net.createServer(conn => {
+            if(!conn.resetAndDestroy) {
+                conn.resetAndDestroy = () => {
+                    conn._handle.reset(() => {
+                        this.conn.emit("close")
+                    })
+                    conn._handle.onread = () =>{};
+                    conn._handle = null;
+                }
+            }
             this.dataConn = conn
             this.connections.push(conn)
             this.didOpenDataConn()

diff --git a/test/downloadSpec.js b/test/downloadSpec.js
@@ -148,11 +148,17 @@ describe("Download to stream", function() {
         dataSocket.destroy(new Error("Error that should be ignored because task has completed successfully"))
     })
     it("handles early data socket closure", async () => {
+        /**
+         * type of this.client
+         * @type {Client}
+         */
+        this.client;
+
         this.server.addHandlers({
             "pasv": () => `227 Entering Passive Mode (${this.server.dataAddressForPasvResponse})`,
             "retr": ({arg})  => {
                 //close data connection such that client receives ECONNRESET
-                this.server.dataConn.resetAndDestroy?.()
+                this.server.dataConn.resetAndDestroy()
 
                 return `550 ${arg}: No such file or directory.`
             }