-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
451-Error during read from data connection #205
Comments
Tracked the issue down to transfer.ts
It seems that the dataSocket gets destroyed before all the data is actually sent out by the dataSocket. Should't it be
instead? |
I can confirm that after running the adjusted code (above) for a month now, the problem has not happened even once. |
Thanks! Had the same issue and this solved it. |
Thanks! This fixed also solved my "FTPError: 450 Transfer aborted. Link to file server lost" |
Same issue, solved by that small patch by @PRR24. So how do you people work with this as it doesn't seem to be integrated into basic-ftp? |
I have the same problem, how can I apply the described workaround (besides changing the basic-ftp npm package code locally, which is not really a good idea..)? |
@janwidmer either
I currently work with the second option :< |
@patrickjuchli would you accept a pr to fix this issue? |
Sorry, haven't been aware of this issue for a long time and too busy to do anything here. I wanted to have a look first but if this does help all of you then let's just do this. Yes, will accept PR. Thanks all, and sorry again. |
Update event for closing/destroying the socket for uploads from finish to end Fixes patrickjuchli#205
Update event for closing/destroying the socket for uploads from finish to end Fixes #205
If has been addressed in #212 but apparently it failed to build and there's no new release. The most recent release on npm is from a year ago. |
I'm working on a fix, I'll use |
Should be fixed in 5.0.0. |
Great, now it works, thanks for the new release. |
Describe the bug
There is a repeatable error during file upload in case of specific file size (around 45k, one specific file size is 45017 bytes) and network speed (fast).
If the file is smaller or larger, the error disappears (file content does not matter). If the network speed is slower, error also disappears. Reproduces with minimal code (new Client + access + uploadFrom), but as is location-specific, is probably very little use. Typically 32k gets uploaded before error appears (but sometimes less)
Possible racing condition?
Problem does NOT depend on:
Ubuntu 18.04
Node v12.22.1
basic-ftp 4.6.6
Would be happy to provide any additional data if requested.
Exception thrown:
Verbose log:
The text was updated successfully, but these errors were encountered: