Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli flag to use --format=json as --json is deprecated #12

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

ksrb
Copy link
Contributor

@ksrb ksrb commented Apr 25, 2022

See ember-template-lint/ember-template-lint#2193

I think this would ideally be combined with some kind of version check to conditionally change the flag.

@patricklx
Copy link
Owner

Hi thanks for the pr.
I think you can use templateLintPackage.versionStr and just check if the first number is >= 4 to validate the version

@patricklx patricklx merged commit 07e76d1 into patricklx:master Apr 27, 2022
@ksrb
Copy link
Contributor Author

ksrb commented Apr 27, 2022

Cool if I run into a project using an older linter version than I'll look into using templateLintPackage.versionStr hopefully everyone is just using the new template linter though 🤞 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants