-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Popups Code #30
Comments
How does it play with quickshare which we have? There is also the open social analytics ticket: #15 |
I've actually not seen quickshare in action, do you have an example handy?
…On Fri, Dec 2, 2016 at 6:21 PM, Cameron Corda ***@***.***> wrote:
How does it play with quickshare which we have?
There is also the open social analytics ticket: #15
<#15>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGmjAKvrIrJOqg-Qq7yQaxs9vdhy5Inks5rEKfhgaJpZM4LCsjl>
.
|
https://github.com/Upstatement/quickshare Sample from their docs:
|
I think quickshare takes care of this sufficiently, closing out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this provides good UX because it opens Facebook and Twitter shares in the same sized popup. I've added this to a bunch of sites and haven't seen any errors with it. Works as expected on mobile. What do you guys think of dropping it into bubs?
The text was updated successfully, but these errors were encountered: