Skip to content

Commit

Permalink
Increase the test coverage.
Browse files Browse the repository at this point in the history
  • Loading branch information
alexeyklyukin committed Oct 19, 2015
1 parent 11073ac commit 4e44801
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
8 changes: 7 additions & 1 deletion tests/test_ha.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import etcd
import unittest

from mock import Mock, patch
from mock import Mock, MagicMock, patch
from patroni.dcs import Cluster, Failover, Leader, Member
from patroni.etcd import Client, Etcd
from patroni.exceptions import DCSError, PostgresException
Expand Down Expand Up @@ -130,6 +130,12 @@ def test_recover_master_failed(self):
self.ha.has_lock = true
self.assertEquals(self.ha.run_cycle(), 'removed leader key after trying and failing to start postgres')

@patch('sys.exit', return_value=1)
@patch('patroni.ha.Ha.sysid_valid', MagicMock(return_value=True))
def test_sysid_no_match(self, exit_mock):
self.ha.run_cycle()
exit_mock.assert_called_once_with(1)

@patch.object(Cluster, 'is_unlocked', Mock(return_value=False))
def test_start_as_readonly(self):
self.p.is_leader = self.p.is_healthy = false
Expand Down
4 changes: 4 additions & 0 deletions tests/test_postgresql.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,3 +429,7 @@ def test_cleanup_archive_status(self, mock_file, mock_link, mock_remove, mock_un
self.p.cleanup_archive_status()
mock_unlink.assert_not_called()
mock_remove.assert_not_called()

@patch('subprocess.check_output', MagicMock(return_value=0, side_effect=pg_controldata_string))
def test_sysid(self):
self.assertEqual(self.p.sysid, "6200971513092291716")

0 comments on commit 4e44801

Please sign in to comment.