Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add password protection for rclone serve webdav #216

Closed
xiaolei0125 opened this issue Sep 16, 2018 · 5 comments
Closed

Comments

@xiaolei0125
Copy link

@kaczmarkiewiczp , rclone serve webdav is a very useful feature in rcloneExploer, it will always run as a service on my phone, and I'm worried that other people on the LAN will also be able to access it.

So is there a way to add a password protection for webdav? For example, put the password settings in the app settings, thanks.

@patrykcoding
Copy link
Owner

I tested this, and it seems that devices on the same network are able to access served files, as long as they have the IP address and port. After looking at the documentation for rclone serve it seems that I used a wrong flag. Since this is a security issue, I will try to have a fix as soon as possible.

@patrykcoding patrykcoding added the in progress Currently being worked on label Sep 20, 2018
@xiaolei0125
Copy link
Author

@kaczmarkiewiczp
Do you mean to ban access from the LAN?
But sometimes I still want to access webdav from other devices in same network, such as computer or kodi.

@patrykcoding
Copy link
Owner

Reading my response I can see how it can come across as me removing external access. I don't plan to remove any features, sorry for the confusion. The serve dialog is getting revamped, with option to specify external access, and optional authentication.

@patrykcoding
Copy link
Owner

This is now addressed in #217. External access is off by default now, with option to enable it, and there's also option to specify username and password for authentication. All of that is present in the same Serve dialog.

It's part of the current beta release and will be included in future stable release.

@patrykcoding patrykcoding removed the in progress Currently being worked on label Sep 20, 2018
@xiaolei0125
Copy link
Author

@kaczmarkiewiczp Thank you very much, I have tested this beta release and it works very well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants