Skip to content

Commit

Permalink
net: fec: Remove unneeded use of IS_ERR_VALUE() macro
Browse files Browse the repository at this point in the history
[ Upstream commit b0c6ce2 ]

There is no need to use the IS_ERR_VALUE() macro for checking
the return value from pm_runtime_* functions.

Just do a simple negative test instead.

The semantic patch that makes this change is available
in scripts/coccinelle/api/pm_runtime.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Fabio Estevam authored and gregkh committed Dec 9, 2015
1 parent 6077315 commit 914eba9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/ethernet/freescale/fec_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1775,7 +1775,7 @@ static int fec_enet_mdio_read(struct mii_bus *bus, int mii_id, int regnum)
int ret = 0;

ret = pm_runtime_get_sync(dev);
if (IS_ERR_VALUE(ret))
if (ret < 0)
return ret;

fep->mii_timeout = 0;
Expand Down Expand Up @@ -1814,7 +1814,7 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum,
int ret = 0;

ret = pm_runtime_get_sync(dev);
if (IS_ERR_VALUE(ret))
if (ret < 0)
return ret;

fep->mii_timeout = 0;
Expand Down Expand Up @@ -2866,7 +2866,7 @@ fec_enet_open(struct net_device *ndev)
int ret;

ret = pm_runtime_get_sync(&fep->pdev->dev);
if (IS_ERR_VALUE(ret))
if (ret < 0)
return ret;

pinctrl_pm_select_default_state(&fep->pdev->dev);
Expand Down

0 comments on commit 914eba9

Please sign in to comment.