Fixing patternTypePath assignment - Undefined variable: pattern in TwigUtil.php on line 65 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you do not prefix _pattern folders with numbers and dash (00-atoms, 01-molecules) and instead use simply "atoms" and "molecules", the patternTypePath would not get assigned properly as the "else" condition of the ternary logic uses an undefined $pattern variable.
This PR fixes this issue... and will stop the following notice:
php core/console --generate configuring pattern lab... PHP Notice: Undefined variable: pattern in /Users/wadeb/Sites/patterlab-demo/bw-twig-drupal/vendor/pattern-lab/patternengine-twig/src/PatternLab/PatternEngine/Twig/TwigUtil.php on line 65