Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev branch: Config Paths only work with ./ prefix #222

Closed
EvanLovely opened this issue Jan 5, 2016 · 5 comments
Closed

dev branch: Config Paths only work with ./ prefix #222

EvanLovely opened this issue Jan 5, 2016 · 5 comments

Comments

@EvanLovely
Copy link
Member

I'm seeing an issue when using paths in config that do not start with ./: you can't do absolute paths or relative paths that start with ../.

It appears to be from the use of file.substring(2) as an argument used in builder/patternlab.js:93 like this:

pattern_assembler.process_pattern_iterative(file.substring(2), patternlab);
@EvanLovely
Copy link
Member Author

Absolute paths that would start with /Users/Evan/ end up being processed with this at beginning: sers/Evan/

@EvanLovely
Copy link
Member Author

This affected my testing and hopeful use of #216

@bmuenzenmeyer
Copy link
Member

Thanks Evan.

Hmm I thought I tested this quickly with source being a directory up, but you are right I made it relative - so clearly this needs a closer look before it lands or clearer constraints.
Will add this to : #220

@bmuenzenmeyer bmuenzenmeyer modified the milestone: v1.1.0 Jan 8, 2016
@bmuenzenmeyer bmuenzenmeyer changed the title Config Paths only work with ./ prefix dev branch: Config Paths only work with ./ prefix Jan 8, 2016
@bmuenzenmeyer bmuenzenmeyer self-assigned this Jan 14, 2016
@bmuenzenmeyer
Copy link
Member

Now that #230 is in dev, it's time to test. Will do so tonight I hope

@bmuenzenmeyer
Copy link
Member

Tested this. Looks great!
Like usual, this will close when it reaches master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants