Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Code" option not working and some icons not showing #26

Closed
jfitzsimmons2 opened this issue Apr 3, 2014 · 2 comments
Closed

"Code" option not working and some icons not showing #26

jfitzsimmons2 opened this issue Apr 3, 2014 · 2 comments

Comments

@jfitzsimmons2
Copy link

screen shot 2014-04-03 at 3 40 15 pm

Above is a screen shot of the icons not showing. They do work when I install the php version, so I'm not sure where to start debugging. The "Code" option that shows code also works right off the bat in the php version but I haven't been able to get it working in the node version.

Might be relevant: My dev tools is showing on line 453 of styleguide.js, event.data.lineage is returning undefined.

Any suggestions?

@jfitzsimmons2
Copy link
Author

Well, silly me, turns out the icons are just squares in the node version and circles in the php version. So that's settled.

As far as the code view not working. Uncommenting these lines in source/_patternlab-files/index.mustache fixed the issue.

<script src="styleguide/js/annotations-viewer.js "></script>
<script src="styleguide/js/code-viewer.js "></script>

Code viewer works for me now.

@bmuenzenmeyer
Copy link
Member

@jfitzsimmons2 Thanks for catching this one! I recall commenting this out early during the port - as I wanted to utilize @dmolsen awesome client-side work but didn't want to commit to the additional features until some of the internals were ready.

Seems like we are ready - I will give it a whirl and then check out the PR.

@bmuenzenmeyer bmuenzenmeyer added this to the patternlab-node 1.1 milestone Apr 4, 2014
@bmuenzenmeyer bmuenzenmeyer mentioned this issue May 6, 2014
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants