Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean output html in patterns infos #448

Closed
gael-boyenval opened this issue Aug 24, 2016 · 3 comments
Closed

clean output html in patterns infos #448

gael-boyenval opened this issue Aug 24, 2016 · 3 comments

Comments

@gael-boyenval
Copy link
Contributor

gael-boyenval commented Aug 24, 2016

I am using Pattern Lab Node v2.4.3 on Mac, with Node v6, using the Gulp Edition.

Expected Behavior

Our workflow:

  1. front-end dev are building dom éléments and patterns using PL node and mustache.
  2. Back-end guys then go there and pickup the dom in the pattern lab infos panels.

it would be great to get :

maybe with : require('js-beautify').html;

a test here : #449

Actual Behavior

none of that

Steps to Reproduce
@bmuenzenmeyer
Copy link
Member

@gael-boyenval merged and tweaked a bit. overall a good addition!

@gael-boyenval
Copy link
Contributor Author

@bmuenzenmeyer, yes great ! :)
We should maybe add an option to the config file for the indent size.
Every company has his own conventions
What do you think ?

@bmuenzenmeyer
Copy link
Member

I'm opposed to adding minutiae config options like this. I understand that my change might not be what all teams are used to, but their IDE should offer formatting options and ultimately the PL code pane is about readability, which to me, is less scrolling.

That's why I said here that I was hoping we could pass through any found .editorconfig to your PR's code and then truly have people define it that way. To me that's the best long-term solution and for now I'd rather not add an indent property to the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants