Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated patternStates object on patternlab-config.json #619

Closed
3 tasks
bmuenzenmeyer opened this issue Feb 9, 2017 · 7 comments
Closed
3 tasks

Comments

@bmuenzenmeyer
Copy link
Member

The frontmatter/markdown state solution has been in place for a while now, with deprecation warnings emitted by the library.

It's time to remove the old functionality.

  • Remove patternStates from all patternlab-config.json files across repos
  • Remove all signs of setState() within pattern_assembler.js as parsePatternMarkdown() does all the work now.
  • Resolve any unit tests
@benhalverson
Copy link
Contributor

I can give this a shot tonight

@benhalverson
Copy link
Contributor

@bmuenzenmeyer Does patternStateCascade also need to be removed from patternlab-config.json

@bmuenzenmeyer
Copy link
Member Author

@benhalverson
Copy link
Contributor

benhalverson commented Feb 11, 2017

@bmuenzenmeyer Are there any other projects I need to update?
I've made pull requests to the below projects

  • patternlab-node
  • patternlab-node-cli
  • edition-node-grunt
  • edition-node-gulp

@raphaelokon
Copy link
Contributor

raphaelokon commented Feb 11, 2017

@benhalverson I have a couple of stuff in limbo before I merge the PR into cli but it lgtm. Done. Thanks.

@bmuenzenmeyer bmuenzenmeyer self-assigned this Feb 23, 2017
@bmuenzenmeyer
Copy link
Member Author

to my knowledge, all PRs are addressed.

@stale
Copy link

stale bot commented Oct 2, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants