Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

(MQ+ Menu) Media query gathering is gathering all max widths #253

Closed
wpaflightpath opened this issue Nov 10, 2014 · 1 comment
Closed

(MQ+ Menu) Media query gathering is gathering all max widths #253

wpaflightpath opened this issue Nov 10, 2014 · 1 comment

Comments

@wpaflightpath
Copy link

Is there any way to either , possibly in a future release , have the option to define the MQ+ menu to either have specific breakpoints that are set in the data file or to make sure that the gatherMQs function only finds max or min width that exist after a media query call?

I changed the regular expression to this on my local copy of Builder.php, and it does the trick so far, it just makes sure to find an @ sign before the rest of the media query call... I think... I'm not great with regular expressions

preg_match_all("/@.*(min|max)-width:([ ]+)?(([0-9]{1,5})(\.[0-9]{1,20}|)(px|em))/",$data,$matches);

I also wound up commenting out the sort just after this because it was doing an alphabetical and not number sort.

@dmolsen
Copy link
Member

dmolsen commented Jan 3, 2015

@wpaflightpath -

Thanks for catching this. Can't believe I overlooked that. This will be in a future release. See this commit.

@dmolsen dmolsen closed this as completed Jan 3, 2015
@dmolsen dmolsen mentioned this issue Jan 3, 2015
62 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants