Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

PatternStates not working as expected #386

Closed
max-dombrowski opened this issue Mar 30, 2017 · 5 comments
Closed

PatternStates not working as expected #386

max-dombrowski opened this issue Mar 30, 2017 · 5 comments
Assignees

Comments

@max-dombrowski
Copy link

max-dombrowski commented Mar 30, 2017

If i add a pattern state by e.g. add @progress to one pattern, every other pattern that includes a pattern or is included by an other pattern get that state.

So adding state "progress" to a pattern, lets say "base-button", all my other patterns that have includes are on progress. Even if they don't include base-button.

In the docs http://patternlab.io/docs/pattern-states.html is can see there is some kind of state inheritance but this can not be the expected behaviour.

Live example:
image
This pattern have no state suffix in filename, Child-pattern ist complete BUT the pattern ist set to in-review because some other pattern is set to in-review.

I used the node-edition earlier where states are working like a charm.
Any ideas?

@carolinmoll
Copy link

Same Problem here!

@alexcapes
Copy link

Same issue too.

@bradfrost
Copy link
Member

@EvanLovely Is this something you've seen in your recent work touching the pattern states feature?

@EvanLovely
Copy link
Member

Fixed in pattern-lab/patternlab-php-core#139 and released in core v2.8.4

@perriard
Copy link

perriard commented Jan 4, 2018

I am still having this issue - using the twig standard edition. As I can see the core is still on version 2.0.0. Will the twig version be updated too?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants