This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
PatternStates not working as expected #386
Comments
Same Problem here! |
9 tasks
Same issue too. |
@EvanLovely Is this something you've seen in your recent work touching the pattern states feature? |
Fixed in pattern-lab/patternlab-php-core#139 and released in core v2.8.4 |
I am still having this issue - using the twig standard edition. As I can see the core is still on version 2.0.0. Will the twig version be updated too? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If i add a pattern state by e.g. add @progress to one pattern, every other pattern that includes a pattern or is included by an other pattern get that state.
So adding state "progress" to a pattern, lets say "base-button", all my other patterns that have includes are on progress. Even if they don't include base-button.
In the docs http://patternlab.io/docs/pattern-states.html is can see there is some kind of state inheritance but this can not be the expected behaviour.
Live example:
![image](https://cloud.githubusercontent.com/assets/25429198/24503579/f004b23a-1552-11e7-86ce-6907c6543179.png)
This pattern have no state suffix in filename, Child-pattern ist complete BUT the pattern ist set to in-review because some other pattern is set to in-review.
I used the node-edition earlier where states are working like a charm.
Any ideas?
The text was updated successfully, but these errors were encountered: