-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm v3 flattened dependency resolutions #10
Comments
@kahboom @andresgalante We are still in npm2 land and had just attempted running Webpack with Patternfly (as you can see!). Would happily accept a PR for an npm3 update! +1 for removing webpack global install. I followed some other guides on this, but am happy to reference it from Would also be happy to hear any more challenges/successes you have with Webpack. I find myself returning to gulp and anxiously awaiting HTTP2/HTML Import standards, but I'm interested in how the Webpack story plays out. 😉 P.S. Awesome devs like you are always welcome in Patternfly, and we can't thank you enough! |
@priley86 - Thanks, I appreciate the help and would be more than happy to contribute wherever I can. :) I'll be sure to update the README in my PR, which I'll hopefully get around to this/next week. The only issue I can see is that right now, for dev purposes, I'm referencing the CSS from a CDN, as I couldn't get the |
@kahboom sounds good. I noticed the same issue with |
Rm unused string
Rm unused string Update PatternFly to v11.0 Update LESS path for PF v11.0
re #10 Rm unused deps, update paths for npm3, add npm scripts
Hey, thanks for providing this demo app; it's been really useful for integrating PatternFly into an existing project. I have some feedback:
node_modules
directory. The only downside to that would be that you couldn't runwebpack
from the terminal for specific things, you'd need to execute thewebpack
command via npm scripts, but it's still a much safer practice and less headache-y.I'd be happy to assist with these changes if you're currently accepting PRs- unless it's preferable to leave things as is. Either way, let me know. :)
The text was updated successfully, but these errors were encountered: