Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm v3 flattened dependency resolutions #10

Closed
kahboom opened this issue Sep 8, 2016 · 4 comments
Closed

npm v3 flattened dependency resolutions #10

kahboom opened this issue Sep 8, 2016 · 4 comments

Comments

@kahboom
Copy link
Contributor

kahboom commented Sep 8, 2016

Hey, thanks for providing this demo app; it's been really useful for integrating PatternFly into an existing project. I have some feedback:

  1. As of npm 3 all dependencies are flattened, not hierarchical. See here. That basically means that the paths provided for subdependencies, such as here will no longer work if you are using npm 3.
  2. There isn't really a need to install webpack globally, as npm can use the executable binary that is provided within the node_modules directory. The only downside to that would be that you couldn't run webpack from the terminal for specific things, you'd need to execute the webpack command via npm scripts, but it's still a much safer practice and less headache-y.

I'd be happy to assist with these changes if you're currently accepting PRs- unless it's preferable to leave things as is. Either way, let me know. :)

@andresgalante
Copy link
Member

Hi @kahboom thanks for your comment, it'd be great if you can send a PR
cc @priley86

@priley86
Copy link
Member

priley86 commented Sep 9, 2016

@kahboom @andresgalante We are still in npm2 land and had just attempted running Webpack with Patternfly (as you can see!). Would happily accept a PR for an npm3 update!

+1 for removing webpack global install. I followed some other guides on this, but am happy to reference it from node_modules. Please just also update the README. 😄

Would also be happy to hear any more challenges/successes you have with Webpack. I find myself returning to gulp and anxiously awaiting HTTP2/HTML Import standards, but I'm interested in how the Webpack story plays out. 😉

P.S. Awesome devs like you are always welcome in Patternfly, and we can't thank you enough!

@kahboom
Copy link
Contributor Author

kahboom commented Sep 12, 2016

@priley86 - Thanks, I appreciate the help and would be more than happy to contribute wherever I can. :) I'll be sure to update the README in my PR, which I'll hopefully get around to this/next week. The only issue I can see is that right now, for dev purposes, I'm referencing the CSS from a CDN, as I couldn't get the patternfly-sass GitHub repo properly installed with npm (and being version or tag aware). Going to try a few things and will get back to you.

@priley86
Copy link
Member

@kahboom sounds good. I noticed the same issue with patternfly-sass, hopefully we can get this one in npm soon.

kahboom added a commit to kahboom/patternfly-demo-app that referenced this issue Sep 14, 2016
kahboom added a commit to kahboom/patternfly-demo-app that referenced this issue Sep 14, 2016
kahboom added a commit to kahboom/patternfly-demo-app that referenced this issue Sep 15, 2016
Rm unused string

Update PatternFly to v11.0

Update LESS path for PF v11.0
andresgalante added a commit that referenced this issue Sep 16, 2016
re #10 Rm unused deps, update paths for npm3, add npm scripts
@kahboom kahboom closed this as completed Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants