fix(build): remove github pages deploy #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-Next preview: https://patternfly-next-pr-2166.surge.sh |
|
@redallen - do we still need the github pages deploy? |
|
I believe the gh-pages is what's deployed to pf4.patternfly.org . |
|
The DNS entry points at pf-next.netlify.com - this only pushes to patternfly.org/patternfly-next and I'm pretty sure we don't link to that anywhere. Can we turn this off and remove any gh deploy settings from this repo? |
redallen
changed the title
|
Yep, you're correct! Need reapproval @dgutride . |
dgutride
approved these changes
Aug 26, 2019
|
🎉 This PR is included in version 2.27.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt to fix the master build since #2160 only partially worked :)