chore(select): add example of empty menu with a div #2337
Conversation
|
PatternFly-Next preview: https://patternfly-next-pr-2337.surge.sh |
| aria-labelledby="{{id}}-label" | ||
| {{#unless select--IsExpanded}}hidden{{/unless}} | ||
| {{#if select--attribute}} | ||
| {{{select--attribute}}} | ||
| {{/if}}> | ||
| {{#if select--IsEmptyMenu}} |
There was a problem hiding this comment.
should this be select--HasEmptyMenu ?
There was a problem hiding this comment.
I dunno... I think Is[whatever] seems to show an example variation. Like IsExpanded, IsTypeahead, or IsMultiselect identifies the example. IsEmptyMenu shows the empty menu example. I see HasGroups or HasCustomLabel more as a toggle to include something that is optional, though the line seems blurry and I could totally go either way with it :) Let me know if you'd still like me to update it.
There was a problem hiding this comment.
Thanks for the explanation that definitely makes sense from the example side. "Is Empty Menu" just reads strange, but no worries!
|
@christiemolloy rebased and updated since this was using the old hbs format |
|
Approved but there is a conflict |
|
🎉 This PR is included in version 2.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #2333