Skip to content

Commit

Permalink
fix(peer-dependencies): adjust peer dependencies for Angular 8 (#462)
Browse files Browse the repository at this point in the history
Note: PatternFly-ng is not compatible with ngx-bootstrap 3.3.0

For Angular 8, the following must be added to the options of agular.json

```
"options": {
  "preserveSymlinks": true,
```

See: https://stackoverflow.com/questions/53833985/no-provider-for-viewcontainerref-while-using-ng-packagr-component
  • Loading branch information
dlabrecq committed Jun 11, 2019
1 parent 06e46d7 commit bd78ad6
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
9 changes: 7 additions & 2 deletions README.md
Expand Up @@ -6,7 +6,6 @@ Welcome to PatternFly-Ng. This is a library of common Angular components for us
- API Docs: http://www.patternfly.org/patternfly-ng/
- Build Status: https://travis-ci.org/patternfly/patternfly-ng.svg?branch=master


### Using PatternFly-ng In Your Application

This example demonstrates using the Angular-cli to get started with PatternFly-ng
Expand Down Expand Up @@ -54,7 +53,6 @@ import { ToastNotificationModule } from 'patternfly-ng';

```json
"styles": [

"./node_modules/patternfly/dist/css/patternfly.min.css",
"./node_modules/patternfly/dist/css/patternfly-additions.min.css",
"./node_modules/patternfly-ng/dist/css/patternfly-ng.min.css",
Expand All @@ -72,6 +70,13 @@ import { ToastNotificationModule } from 'patternfly-ng';
</pfng-toast-notification>
```

5. For Angular 8, open `angular.json` and insert the following into the options array

```
"options": {
"preserveSymlinks": true,
```

### Optional Dependencies

1. To enable table drag and drop, add dragula.min.css from the ng2-dragula package
Expand Down
10 changes: 5 additions & 5 deletions package.json
Expand Up @@ -93,10 +93,10 @@
"npm": ">=5.6.0"
},
"peerDependencies": {
"@angular/common": "<7.0.0",
"@angular/compiler": "<7.0.0",
"@angular/core": "<7.0.0",
"@angular/forms": "<7.0.0",
"@angular/common": "<8.0.0",
"@angular/compiler": "<8.0.0",
"@angular/core": "<8.0.0",
"@angular/forms": "<8.0.0",
"typescript": "^2.9.2",
"rxjs": "^6.2.2"
},
Expand All @@ -108,7 +108,7 @@
"@swimlane/ngx-datatable": "^13.0.0",
"c3": "^0.4.15",
"ng2-dragula": "^1.5.0",
"ngx-bootstrap": "^3.0.0"
"ngx-bootstrap": "^3.0.0 || <3.3.0"
},
"devDependencies": {
"@angular-devkit/core": "0.7.1",
Expand Down

0 comments on commit bd78ad6

Please sign in to comment.