New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for UMD and es2015 bundles #373
Conversation
Modified a SystemJS based application (using Stan's 'Tour of Heros' app) for testing. The changes for this example can be seen here: Omitted dependencies from UMD and es2015 bundles (e.g., c3, d3, ngx-bootstrap, ngx-datatable, etc.), which allows the application to install different versions. Unlike ES6 modules, the test application required all dependencies to be installed. It's not clear if that's something that can be changed with the example application? |
FYI @ssilvert |
I was able to omit unused dependencies by mapping c3, angular-tree-component, etc. to '@empty', for example. The example app has been updated here: https://github.com/dlabrecq/angular-tour-of-heroes/pull/1/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, tried using a SystemJS app as well as an app running angular + angular cli, was able to consume the entire patternfly-ng library, or individual pfng modules without issue.
LGTM - nice work!
6d9f1f7
to
596afce
Compare
Per @ssilvert 's suggestion, I've removed the babel plugin from the example application and everything worked as expected. Unless there are any further comments, I'll merge shortly? |
Sounds great, Dan. Please let me know when there is a build I can try out. |
This is a work in progress, but I've added support for UMD and es2015 bundles. Needs further testing with a SystemJS based application.
Fixes: #366