Individual module imports for navigation components #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows components to be imported individually without having to install an unused, optional dependency. Deprecations - NavigationItemConfig: Use NavigationBaseConfig, VerticalNavigationConfig, or ApplicationLauncherConfig - NavigationModule: Use ApplicationLauncherModule or VerticalNavigationModule
dlabrecq
added a commit
to dlabrecq/patternfly-ng
that referenced
this pull request
Jun 18, 2018
…atternfly#393) This allows components to be imported individually without having to install an unused, optional dependency. Deprecations - NavigationItemConfig: Use VerticalNavigationItem or ApplicationLauncherItem - NavigationModule: Use ApplicationLauncherModule or VerticalNavigationModule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual module imports for navigation components.
This allows components to be imported individually without having to install an unused, optional dependency.
Deprecations
Note: Backed out #377 to address a git commit issue with Travis. Adding code back in one module at a time.