fix(peer-dependencies): adjust peer dependencies for Angular 8 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: PatternFly-ng is not compatible with ngx-bootstrap 3.3.0
For Angular 8, the following must be added to the options of agular.json
```
"options": {
"preserveSymlinks": true,
```
See: https://stackoverflow.com/questions/53833985/no-provider-for-viewcontainerref-while-using-ng-packagr-component
dgutride
approved these changes
Jun 11, 2019
|
Deploy preview for patternfly-ng ready! Built with commit 6a6a58c |
|
🎉 This PR is included in version 4.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the peer dependencies for Angular 8.
In addition, I've modified the ngx-bootstrap dependency, as PatternFly-ng is not compatible with the dropdown of ngx-bootstrap v3.3.0. Tested v3.0.0-v3.2.0 and they worked fine.
For Angular 8, the following must be added to the options of agular.json
See: https://stackoverflow.com/questions/53833985/no-provider-for-viewcontainerref-while-using-ng-packagr-component