Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add dark theme switcher #3014

Merged
merged 4 commits into from
Jul 5, 2022

Conversation

evwilkin
Copy link
Contributor

@evwilkin evwilkin commented Jun 16, 2022

Closes #2885
Closes #2959

This PR adds a dark theme switcher to the website. No designs to work from so open to feedback.

Note: current code will expose switcher on the live site & not in the workspaces. Once design is confirmed & approved, we'll need to edit the patternfly-docs.config.js file in each repo separately to add the hasDarkThemeSwitcher property to the exports & set it to true (to show the switcher) or false (to not render the switcher).

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 16, 2022

@evwilkin evwilkin force-pushed the chore/2885-dark-theme-switcherr branch from c036b2b to 5a078c1 Compare June 17, 2022 15:41
@evwilkin evwilkin marked this pull request as ready for review June 24, 2022 20:47
@evwilkin
Copy link
Contributor Author

FYI @mcoker @nicolethoen I've updated this PR to disable the theme switcher in org (hasDarkThemeSwitcher = false) but this adds the mechanism to pull it in & enable is separately in core & react 🪄

@mcoker mcoker changed the title chore(docs): add dark theme switcher feat(docs): add dark theme switcher Jul 5, 2022
@mcoker mcoker merged commit 7d17d13 into patternfly:main Jul 5, 2022
@septatrix
Copy link

FYI @mcoker @nicolethoen I've updated this PR to disable the theme switcher in org (hasDarkThemeSwitcher = false) but this adds the mechanism to pull it in & enable is separately in core & react magic_wand

Why did you disable this? Is it because it is not yet fully supported?

@evwilkin
Copy link
Contributor Author

evwilkin commented Oct 6, 2022

@septatrix dark theme was added in a Beta status as it was built out specifically around the needs of particular product, and does not yet have widespread support across all PF components. Additionally, our website doesn't have any built-in support for displaying dark theme correctly, so while some components would look correct there are many other things that would need to be updated (screenshots, limiting which areas of the page are affected by a theme toggle, etc) that need to be considered & updated for the site to effectively display dark theme examples.

We are currently planning on how to revamp theming within PatternFly & roll out official support for an updating system with our next major release, and will be discussing website updates in the coming weeks, so hope to have a more concrete plan around all of this later this year.

jessiehuff pushed a commit to jessiehuff/patternfly-org that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace - add dark theme switcher Apply dark theme with switcher to org
5 participants