-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): add dark theme switcher #3014
feat(docs): add dark theme switcher #3014
Conversation
PF4 preview: https://patternfly-org-pr-3014-v4.surge.sh/v4 |
c036b2b
to
5a078c1
Compare
FYI @mcoker @nicolethoen I've updated this PR to disable the theme switcher in org ( |
Why did you disable this? Is it because it is not yet fully supported? |
@septatrix dark theme was added in a Beta status as it was built out specifically around the needs of particular product, and does not yet have widespread support across all PF components. Additionally, our website doesn't have any built-in support for displaying dark theme correctly, so while some components would look correct there are many other things that would need to be updated (screenshots, limiting which areas of the page are affected by a theme toggle, etc) that need to be considered & updated for the site to effectively display dark theme examples. We are currently planning on how to revamp theming within PatternFly & roll out official support for an updating system with our next major release, and will be discussing website updates in the coming weeks, so hope to have a more concrete plan around all of this later this year. |
Closes #2885
Closes #2959
This PR adds a dark theme switcher to the website. No designs to work from so open to feedback.
Note: current code will expose switcher on the live site & not in the workspaces. Once design is confirmed & approved, we'll need to edit the
patternfly-docs.config.js
file in each repo separately to add thehasDarkThemeSwitcher
property to the exports & set it to true (to show the switcher) or false (to not render the switcher).